prusa3d / Prusa-Firmware

Firmware for Original Prusa i3 3D printer by PrusaResearch
GNU General Public License v3.0
1.99k stars 1.05k forks source link

Add nozzle diameter change to main menu for REVO builds #4563

Closed 3d-gussner closed 5 months ago

3d-gussner commented 6 months ago

Add Nozzle diameter to Info screen when printer inactive and QUICK_NOZZLE_CHANGE defined

Solves #4488

Only active by default on REVO builds Info screen idle Info_screen_idle_with_Nozzle_diameter

Main menu Main_menu_Nozzle_diameter

github-actions[bot] commented 6 months ago

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 0 0 246688 5656 7264 2536
MK3_MULTILANG 0 0 245978 5663 7974 2529
3d-gussner commented 6 months ago

@alexiri, @kromeninja, @ulab, @JWvP, @snafu1282, @matthiazzz, @sdh2, @davejhilton, @D-an-W, @MaroonOut09 As you have been very active with the REVO TM calibration I would like to know what you think of this request and PR Please vote with :+1: or :-1: and/or leave a comment

trfunk commented 6 months ago

Big fan of this change, it would be very useful to me.

One small cosmetic thing I'd personally prefer (maybe someone else can chime in too), on the Info Idle screen, I'd either remove the "." or the "d" and move the numbers one to the left, so it lines up with the Z xx.xx two lines up. I sketched it really quick in paint: grafik

3d-gussner commented 6 months ago

@trfunk Thanks for the feedback and suggestion. When the printer starts the Z has a ? at the end. Here are the different Idle Info screens

  1. No other Sheet calibrated Thu Jan 11 07:11:10 2024
  2. At least two sheets calibrated Thu Jan 11 07:11:26 2024
  3. At least two sheets calibrated and MMU3 enabled Thu Jan 11 07:11:46 2024
  4. No other Sheet calibrated and MMU3 enabled Thu Jan 11 07:12:14 2024
  5. While SD printing Thu Jan 11 07:13:29 2024

I leave it to the community to decide which they want to have :rocket: Nd. 0.40 :tada: N. 0.40 :eyes: Nd 0.40

D-an-W commented 6 months ago

Thanks for the continued development @3d-gussner, always appreciated and this will remind me in a small way to utilise my other nozzles more!

While we are talking about cosmetic changes I always think MK3S-R along the bottom would look better as MK3S+R :)

3d-gussner commented 6 months ago

Thanks for the continued development @3d-gussner, always appreciated and this will remind me in a small way to utilise my other nozzles more!

The idea came from @LoakAudio and as it is an "easy" PR I took few minutes to prepare it.

While we are talking about cosmetic changes I always think MK3S-R along the bottom would look better as MK3S+R :)

Again a vote from the community would be helpful. :rocket: Prusa i3 MK3S-R and Prusa MK3-RHF60 :tada: Prusa i3 MK3S+R and Prusa MK3+RHF60

3d-gussner commented 6 months ago

Thanks for the feedback and here the minor cosmetic changes you voted for. Fri Jan 12 07:07:15 2024

This PR uses 188 bytes extra Flash when QUICK_NOZZLE_CHANGE is defined in variant file.

3d-gussner commented 6 months ago

Added milestone FW3.14.0 as it only changes the REVO community build.

D-an-W commented 4 months ago

Added milestone FW3.14.0 as it only changes the REVO community build.

Am I correct in saying we won't see these changes until 3.14.0?