Closed ilka-schulz closed 4 months ago
All values in bytes. Δ Delta to base
Target | ΔFlash | ΔSRAM | Used Flash | Used SRAM | Free Flash | Free SRAM |
---|---|---|---|---|---|---|
MK3S_MULTILANG |
0 | 0 | 246786 | 5657 | 7166 | 2535 |
MK3_MULTILANG |
0 | 0 | 246068 | 5664 | 7884 | 2528 |
This is a brute force solution. It will break some users system packages for sure. (Hence the name)
You should use a virtual environment instead.
Me too. I hate pip, but the suggestion it writes is correct: use the system package if available, or use a virtualenv. --break-system-packages can work in some scenarios, but for most users it's a sure-fire way to mess up python.
Ah, I understand the critic. I am a Qubes user so I never need to bother about broken packages, thus I overlooked the regression this PR would introduce. Maybe in that case, the script should offer some option to use --break-system-packages
anyways? Using virtual environments sounds unnecessarily convoluted to me...
I would not do that. Keep in mind that users of this script aren't necessarily advanced users that understand the implications of what they are doing and so passively enabling them to pick the single wrong thing out of three possibilities isn't good.
We should either set up a virtualenv and use it, or offer them guidance on which packages to install via the system package manager in this scenario. Unfortunately it's tricky to automate the latter because not all distros use the same naming or package management scripts.
@ilka-schulz After all the comments I added a won't fix
label as we will not merge is PR as it is. Thanks for the PR anyway always appreciated. Maybe we get another solution for the issue because of it.
Closing as we won't use this fix
See PEP 668 for the detailed specification.
This PR mitigates the issue that pip3 under Debian 12 will refuse to install packages and thus breaks
bootstrap.py
:running again with the change of this PR: