search

prusa3d / Prusa-Firmware

Firmware for Original Prusa i3 3D printer by PrusaResearch
GNU General Public License v3.0
1.99k stars 1.05k forks source link

Stop print when SDcard is removed while printing. #4662

Closed 3d-gussner closed 2 months ago

3d-gussner commented 2 months ago

Stop print when SD card is removed

github-actions[bot] commented 2 months ago

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 12 0 247470 5653 6482 2539
MK3_MULTILANG 12 0 246748 5662 7204 2530
mkbel commented 2 months ago

Does it really stop the print or pause the print?

3d-gussner commented 2 months ago

@mkbel It stops the print. To ensure that the printer doesn't stay heated above the print.

Pausing the print needs way more investigation.

mkbel commented 2 months ago

I don't think you need to check anything (if the file is the same or not) upon re-insertion. If the user modifies the file it is his fault. In Buddy firmware print is paused when USB flash drive is removed during the print. And I don't think Buddy firmware checks anything when the print is resumed. It would be nice to have the same behaviour across our product range.

Patronics commented 2 months ago

I don't think you need to check anything (if the file is the same or not) upon re-insertion. If the user modifies the file it is his fault.

I was just recently thinking that this could actually be a useful feature to specifically allow, I've had a project where I realized partway through I'd made a mistake near the top of the print, but no changes were needed to the lower portion. I'd speculated as to whether I could remove the SD card (or flash drive, in that case, it was a Prusa Mini), reslice the file (being careful to keep the position, support, slicing settings, etc unchanged), and reinsert it to allow it to resume with the fix.

Having that officially supported (at the user's own risk, of course), would be really useful to save or fix long prints sometimes!

3d-gussner commented 2 months ago

Closing as it may cause more issues than solving.