prusa3d / Prusa-Link-Web

Prusa Web interface resources
GNU General Public License v3.0
114 stars 50 forks source link

Add .bgcode to FILE_EXTENSIONS #474

Closed domiko96 closed 5 months ago

domiko96 commented 5 months ago

This allows easier uploading of .bgcode files. Currently the browser upload UI will only allow to upload .gcode files at first. You have to manually choose Format all files in chrome.

image image

This was reported in issue https://github.com/prusa3d/Prusa-Link-Web/issues/455

Lowentwickler commented 5 months ago

Thank you, but tis is not the right place for the change. It must be applied to a printer's config. On some printer models, the config is a part of a firmware. Only Prusa Mini's config is covered by this repo and it is already there.

domiko96 commented 5 months ago

@Lowentwickler thanks for reviewing. I assumed something like that. In this case it is wrong in 5.1.2 with the MK4, but I guess you're already fixing it.

iridris commented 5 months ago

Thank you, but tis is not the right place for the change. It must be applied to a printer's config. On some printer models, the config is a part of a firmware. Only Prusa Mini's config is covered by this repo and it is already there.

When you say "it is already there" - do you mean the filter including .bgcode is already on the mini's? If that's the case - then no, the Mini does not properly show .bgcode when uploading a file - it still only lists gcode unless you change it to "All files".

While this PR may not fix the MK4, it would fix the Mini, so possibly this should be re-opened?

ondratu commented 5 months ago

The bug is fixed yet, see: https://github.com/prusa3d/Prusa-Link-Web/blob/master/config.mini.js. This file (we know about bad name) is used for all buddy printers, includes MINI, MK3.9, MK4, XL. Next release will has it. If you want to compile your own firmware, will be included.

vkorenev commented 4 months ago

@ondratu, I have Prusa MK4 printer with firmware version 5.1.3+13503 installed on it. It was released on January 24: https://github.com/prusa3d/Prusa-Firmware-Buddy/releases/tag/v5.1.3 The bug is still there: Screenshot from 2024-03-03 15-56-37

hackwin commented 4 months ago

It would be nice if the web server portion of the firmware could be in an editable format that doesn't require compilation.

Such as Node.js, PHP, Python, etc.