prusa3d / PrusaControl

PrusaControl is an alternative user interface for Slic3r Prusa Edition
http://prusacontrol.org
GNU General Public License v3.0
128 stars 45 forks source link

G1 G-code parsing is broken leading to import hang #119

Open LeadAssimilator opened 5 years ago

LeadAssimilator commented 5 years ago

Broken G1

The G1 G-code must have at least one parameter, but the PursaControl parsing code, namely gcode.py's parse_g1_line_new, is expecting at least two when the first parameter is Y, and throws an exception that is uncaught, breaking loading and the UI.

When only X is present, the entire G-code is ignored.

Examples

G1 X179.750 ; I will be completely ignored G1 Y185.250 ; I will exception and break loading and the UI

Workarounds

If you experience any issues with importing gcode files it is more than likely G1 or some other code that is not properly handled. It can usually be worked around by adding dummy parameters to the affected codes, or stop using PrusaControl since it appears to be broken and dead.

prusa3d-bb commented 5 years ago

Hello,

thank you for your feedback related to G-code. Unfortunately the Prusa Control is no longer supported, because all of the features and properities will be moved to out Slic3r by Prusa.

Kind regards,

— Šimon Doubek Customer Support

PRUSA Research

+420 222 263 718

+421 220 570 305

188/7a Partyzánská, 17000, Prague

shop.prusa3D.com

For simple troubleshooting, please use: http://help.prusa3d.com

--- original message --- On November 26, 2018, 7:20 AM GMT+1 notifications@github.com wrote:

Broken G1

The G1 G-code must have at least one parameter, but the PursaControl parsing code, namely gcode.py's parse_g1_line_new, is expecting at least two when the first parameter is Y, and throws an exception that is uncaught, breaking loading and the UI.

When only X is present, the entire G-code is ignored.

Examples

G1 X179.750 ; I will be completely ignored

G1 Y185.250 ; I will exception and break loading and the UI

Workarounds

If you experience any issues with importing gcode files it is more than likely G1 or some other code that is not properly handled. It can usually be worked around by adding dummy parameters to the affected codes, or stop using PrusaControl since it appears to be broken and dead.

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or mute the thread. --- end of original message ---