Thin walls: improvement

supermerill commented 6 years ago

Hi, I just slain my personal dragon by improving the thin wall algorithm.

no more strange turn at end => fusion of voronoi end lines when they are near enough
anchoring inside the perimeters => extends the lines end inside the perimeter to join it. A gui parameter can be created to adjust it if needed (currently, it extends to meet the center).
conservation of too small segments of thin walls when they are crossing each other => modification of the fusion algorithm to select the most strait path instead of a random one
no more cutting of small walls path by the gcode writer (no_sort for each thin wall extrusion) to have nice long lines of extrusions instead of many smaller.

before:

smallwall_problem thin_wall_badd

after:

thin_wall_happy thin_wall_success

Do you want a pull request?

for the curious: f6854427eb8ab44c3beddda2dc5386c73cda08e3

lordofhyphens commented 6 years ago

This has been merged into upstream Slic3r

bubnikv commented 6 years ago

@lukasmatena Would you please review this code? Thanks.

supermerill commented 6 years ago

If you want to make a code review, i should create a pull request as all the needed code isn't in this commit.

wavexx commented 5 years ago

Would you make a proper PR for this? I think it would also be helpful also for prusa to keep track of other tweaks you did beyond the mentioned commit (if any).

supermerill commented 5 years ago

I will update it when the one in the mainline branch will be merged.

wavexx commented 5 years ago

There's so much development to love both in slic3r mainline and prusa's fork... :cry: I switch between the two depending on the part I need to print!

prusa3d / PrusaSlicer

Thin walls: improvement #1028

before:

after: