prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.63k stars 1.92k forks source link

Emit temperature commands automatically: support Klipper PRINT_START #11597

Closed viesturz closed 10 months ago

viesturz commented 10 months ago

Description of the bug

On Klipper it's typical to pass initial temps to the PRINT_START macro and let printer smartly prepare for printing, including any thermal soaking, etc.

Extend the heuristic to detect this flavor.

Or maybe better - check if the script reads the temperature variables and don't try to decypher how exactly they are converted into Gcode. That would be more robust across different firmwares and Gcode flavors.

https://github.com/prusa3d/PrusaSlicer/blob/e86cd23b452f43972d3cbb53abe97ce5e7fe0cec/src/libslic3r/GCode.cpp#L1716

Project file & How to reproduce

Use the following start GCode: PRINT_START TOOL_TEMP=[first_layer_temperature[initial_tool]] BED_TEMP=[first_layer_bed_temperature] TOOL=[initial_tool]

Checklist of files included above

Version of PrusaSlicer

2.6.1

Operating system

Win11

Printer model

voron 2.4

lukasmatena commented 10 months ago

Could you please expand on what problem are you trying to solve? I believe that all you need to do is to disable the checkbox "Emit temperature command automatically" (which was added specifically for this use case, see #2420) and all should be great.

viesturz commented 10 months ago

Yes disabling the checkbox is a valid workaround.

But I spent 1 hour debugging what the hell was wrong after setting up a new Voron profile. I imagine I'm not alone here. And since the automation exists and is enabled by default, it should work by default.

Another possible fix would be to disable it in Klipper based profiles.

On Mon, Nov 6, 2023, 10:35 Lukáš Matěna @.***> wrote:

Could you please expand on what problem are you trying to solve? I believe that all you need to do is to disable the checkbox "Emit temperature command automatically" (which was added specifically for this use case, see

2420 https://github.com/prusa3d/PrusaSlicer/issues/2420) and all

should be great.

— Reply to this email directly, view it on GitHub https://github.com/prusa3d/PrusaSlicer/issues/11597#issuecomment-1794415286, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMQT43KLJL6253UOSGSVSDYDCVNHAVCNFSM6AAAAAA66IWUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGQYTKMRYGY . You are receiving this because you authored the thread.Message ID: @.***>

rtyr commented 10 months ago

On Klipper it's typical to pass initial temps to the PRINT_START macro

As far as I know, it is mainly typical for Voron users, but its not needed at all for running Klipper printer.

I really don't see any issue here. You can just disable the checkbox and set what do you want.

viesturz commented 10 months ago

In that case please change the default for Voron profiles, thanks!

On Tue, Nov 7, 2023, 12:39 rtyr @.***> wrote:

On Klipper it's typical to pass initial temps to the PRINT_START macro

As far as I know, it is mainly typical for Voron users, but its not needed at all for running Klipper printer.

I really don't see any issue here. You can just disable the checkbox and set what do you want.

— Reply to this email directly, view it on GitHub https://github.com/prusa3d/PrusaSlicer/issues/11597#issuecomment-1798336513, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMQT472PRCLSWQHOIV6CZ3YDIMWLAVCNFSM6AAAAAA66IWUD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGMZTMNJRGM . You are receiving this because you authored the thread.Message ID: @.***>

rtyr commented 10 months ago

In that case please change the default for Voron profiles.

Disabled with configuration update 1.0.4. Closing.

marcomania75 commented 9 months ago

i am happy I found this, suddenly my little 0.1 wasn't working anymore,... canceled every new print...

ogabriel commented 5 months ago

Yes disabling the checkbox is a valid workaround. But I spent 1 hour debugging what the hell was wrong after setting up a new Voron profile. I imagine I'm not alone here. And since the automation exists and is enabled by default, it should work by default. Another possible fix would be to disable it in Klipper based profiles.

I also agree this should be turned off by default on klipper profile

I also spent some minutes trying to figure out why START_PRINT macro started to suddenly heat up on the start LoL