prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.75k stars 1.93k forks source link

Comma not accepted as decimal separator in various fields #11789

Open murk-sy opened 11 months ago

murk-sy commented 11 months ago

Description of the bug

While most fields allow using comma as decimal separator and automatically converting it to a period, not all do. This seems to to be the case on all modal settings, but not for those modified in the main application window.

Entering "9,2" into both fields:

image

image

Project file & How to reproduce

Fields where comma is ignored from entering:

Fields where comma works properly:

Checklist of files included above

Version of PrusaSlicer

2.7.0

Operating system

Windows 10

Printer model

Mini/XL

Edit 2024-06-22: Reproducible in 2.8.0-beta1

Jony01 commented 11 months ago

Separator for decimal and floating part of number depends on language you are using. https://en.wikipedia.org/wiki/Decimal_separator#Examples_of_use Question is which behavior is more correct? BTW: What is your personal reason of using , instead of . ?

murk-sy commented 11 months ago

Technically, it's based on the system locale, which is not necessarily the same as system language, but that's splitting hairs.

All my up-to-date software is able to accept comma as decimal separator, Fusion 360 being the main example. I have either English or Slovenian as the language, but locale is always Slovenian (for correct time/number formats).

Considering the vast majority of 3D printing right now is relatively small, the existence of thousands (and other similar) separators can largely be ignored. This means that either period or comma can easily be interpreted as "decimals follow".

I use comma because it is, as far as my locale is concerned (in both a physical and electronic sense), the correct one. The other reason is numpad number entry, which has a comma.