prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.5k stars 1.9k forks source link

Add physical printer browser option for Moonraker API #11831

Open ianc1215 opened 7 months ago

ianc1215 commented 7 months ago

Describe the solution you'd like I would like PS to search for "_moonraker._tcp.local" when the Host Type is set to Klipper (via Moonraker) instead of search for "_octoprint._tcp.local"

Describe how it would work The current release of PS 2.7.0 will connect to a Moonraker instance when entered into the IP address field. However I advertise via mDNS my Moonraker instance as "_moonraker._tcp.local". After inspecting network traffic with Wireshark I have found that PS is looking for "_octoprint._tcp.local" no matter which options is select for the type Host Type. While functionally it's more of a cosmetic feature, the addition of querying for a specific mDNS record for each specific host type make a lot more sense. Moonraker does have Octoprint support, but Moonraker isn't Octoprint. The 2 should not be looking for the same resource on the network.

Describe alternatives you've considered The only alternative is to just setup an avahi service configuration that advertises "_octoprint._tcp.local". While this would work there really should be a definition for Moonraker since it's not Octoprint.

Additional context Add any other context or paint drawing about the feature request here. Wireshark_8YsYPJlQYE prusa-slicer_XkN22M5zj6

eduncan911 commented 3 months ago

I second this motion.

As a firmware engineer, it's just annoying because we do not run octoprint.