prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.75k stars 1.93k forks source link

Layer Editing: Suggestions for better usability #119

Closed MartinMajewski closed 4 years ago

MartinMajewski commented 7 years ago

Version

1.33.3

I like the direction the development goes with the layer height editing. However, there are several suggestions I want to make for further consideration.

Sharp steps in layer height changes would be useful. As seen in the screenshot provided the top end of my adjustment is always smoothed out. The last couple of layers gets higher again, which is not what I want. In fact, the last layer (the topmost it is) is 0.12 mm, the second last is 0.09 mm, and from then all other layers are at the minimum of 0.07 mm until the bumpy gradient starts. That is the best I could get with clicking, shift+clicking, clicking and so forth.

With the current control scheme, it is not easily possible to adjust it correctly. On the one hand, there is some smoothening/interpolation going on internally. On the contrary, moving the curvature around by digitally clicking and scrolling will always be guesswork depending on luck and persistence. So besides the request for removing the interpolation for the first and last layer, I would also suggest the following:

Revamp the control scheme in a way that provides something like splines with control points and tangent lines. Look at vector drawing tools like Illustrator or Affinity Designer, or any other tool that uses splines to interpolate a function. The control points can have characteristics for interpolation like a discrete or continuous interpolation. Setting points onto a canvas is a far easier procedure than doing analog sculpting with a PC-mouse. With the current Layer Editor, I feel a little bit like I would use Mudbox inside slic3r. :-D

Best wishes, Martin screen shot 2017-02-10 at 18 39 47

landodragon141 commented 7 years ago

I agree with this, I would like to be able to specify specific layer "steps" i.e. 0.08 > 0.12 > 0.24 > 0.36.

MartinMajewski commented 7 years ago

Nevertheless, the current control scheme fits perfectly with the overall slic3r UI madness, where nothing is controlled the same way nor controlled within a constant level of detail, and everything is scattered around, hidden, behind a context menu, or showed as a popup menu. :-P

landodragon141 commented 7 years ago

👍 :-)

bubnikv commented 7 years ago

Martin,

would you please provide a config.ini and export an AMF file with the layer edited the way it is on the screenshot? The top most layer should certainly be editable. If it is not, then it is a bug.

Revamp the control scheme in a way that provides something like splines with control points and tangent lines.

I was surely thinking about it. It really depends on the use case of the tool. If you have a complex decorative object, the current UI is IMHO very good in allowing you to have a quick control over print detail and smoothness of the transitions. At least our prints we have done internally supports this.

Look at vector drawing tools like Illustrator or Affinity Designer, or any other tool that uses splines to interpolate a function. The control points can have characteristics for interpolation like a discrete or continuous interpolation. Setting points onto a canvas is a far easier procedure than doing analog sculpting with a PC-mouse.

In my experience working with splines is cumbersome. It may be good for technical work where you want to achieve a prescribed profile. But most of the time the variable layer height will be used to make the top surfaces of 3D benchies and tree frogs nicer, and for this purpose the current UI is adequate.

I am open for discussion. Let's wait for more feedback.

Nevertheless, the current control scheme fits perfectly with the overall slic3r UI madness, where nothing is controlled the same way nor controlled within a constant level of detail, and everything is scattered around, hidden, behind a context menu, or showed as a popup menu. :-P

This is an open source project. You are most welcome to join the development and polish the UI, if you have the time and abilities.

bubnikv commented 7 years ago

The last couple of layers gets higher again, which is not what I want. In fact, the last layer (the topmost it is) is 0.12 mm, the second last is 0.09 mm, and from then all other layers are at the minimum of 0.07 mm until the bumpy gradient starts. That is the best I could get with clicking, shift+clicking, clicking and so forth.

This has been addressed by the following change: https://github.com/prusa3d/Slic3r/commit/4d739c41a00250508b9c31c8e66b8f59e505ce2e

bubnikv commented 4 years ago

We will not implement spline controls. A bug mentioned was fixed. The sharp layer transitions may newly be edited with the layer height table at the object list. Closing.