prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.74k stars 1.93k forks source link

Negative text object name does not get updated after editing #12942

Open nmaggioni opened 4 months ago

nmaggioni commented 4 months ago

Description of the bug

When adding or copying a negative volume text object and editing its content, the name of the entity in the parts list side panel is not updated until a change is tried to be made to it. The custom name is then immediately discarded and the new, automatically assigned name correctly reflects the new text contents.

https://github.com/prusa3d/PrusaSlicer/assets/3594528/50d8201d-5f54-47f3-b189-763a5972d95d

Project file & How to reproduce

  1. Add Shape > Box.
  2. (On the newly created part) Add negative volume > Text.
  3. Edit the text to contain a custom string and close the dialog.
  4. Notice how the name of the entity in the sidebar is still "Text - Embossed text".
  5. Click on the name of the entity in the sidebar and rename it to a different value (or just click away without editing the original value).
  6. Notice how triggering the edit made the correct object name appear.

These steps are shown in the video above by copying and pasting the same text object inside an existing part.

Checklist of files included above

Version of PrusaSlicer

2.7.4

Operating system

Manjaro Linux

Printer model

Any

Jony01 commented 4 months ago

I confirm, it is reproducible.

nmaggioni commented 4 months ago

Seems to persist in v2.8.0, and text in the form of positive shape misbehaves too: on edit the label Text - is prepended each time a modification is made even if it's already present. Repeatedly double clicking on the object name and then clicking out without making edits results in something like this: Text - Text - Text - Text - Embossed text.