prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.63k stars 1.92k forks source link

Thin wall detection reversed #1389

Open ArjanStr opened 5 years ago

ArjanStr commented 5 years ago

Version

1.41.1+win64

Use About->About Slic3r for release versions

For -dev versions, use git describe --tag or get the hash value for the version you downloaded or git rev-parse HEAD

Operating system type + version

Windows10

Behavior

If thin wall detection is checked, slicer does NOT detect thin walls. The selection is reversed.

Is this a new feature request?

STL/Config (.ZIP) where problem occurs

Upload a zipped copy of an STL and your config (File -> Export Config)

lostcontrol commented 5 years ago

Ah yes, seems you're right. Good catch!!!

bubnikv commented 5 years ago

@FidelCapo would you please confirm this? Thanks.

FidelCapo commented 5 years ago

I am not able to reproduce this error. I've tested the "detect thin perimeters" feature on the attached object, and it seems to me that the function works correctly.

Model sliced with "detect thin perimeters" feature disabled

screenshot 2018-11-15 at 10 33 31

Model sliced with "detect thin perimeters" feature enabled

screenshot 2018-11-15 at 10 34 39

Can you please send me a 3MF file where the issue is showing?

lostcontrol commented 5 years ago

This is with the option enabled: screenshot from 2018-11-15 22-23-52 and this with the option disabled: screenshot from 2018-11-15 22-24-27 Look at the 4 holes at the left and right of the object. Actually the setting is called "Detect thin walls"

wavexx commented 5 years ago

I also have some weird issues with "thin wall" detection. As the OP, I mostly do mechanical parts, and design features with exact perimeter sizes in mind.

The option works mostly as intended. A 0.4mm wall will not be printed with a 0.4mm nozzle unless the option is switched on.

However, there are definitely some corner cases where thin wall detection actually prevents some thin (and not so thin) features to be printed. I'm trying to find the specific cases where I had this problem in the past and post some models.

bubnikv commented 5 years ago

@lostcontrol The first image shows the effects of the thin walls detection to me indeed, so the switch is certainly correct, only the "detect thin walls" does not work optimally. Your model is a good test object for @supermerill , who is currently reworking the gap fill algorithm.

supermerill commented 5 years ago

gap fill algorithm

It's in the review process in slic3r upstream. If/when merged, I will do the same here.

lostcontrol commented 5 years ago

@bubnikv ok, makes sense. @supermerill here is the STL file. I use 3 shells and I think my layer width should be at 0.45mm. I can export a AMF or 3MF file if you want.

supermerill commented 5 years ago

@ lostcontrol I don't know why you give me this stl but i can slice it and i can have thin walls. thin_toad

lostcontrol commented 5 years ago

@supermerill because @bubnikv said a few comments that:

@lostcontrol The first image shows the effects of the thin walls detection to me indeed, so the switch is certainly correct, only the "detect thin walls" does not work optimally. Your model is a good test object for @supermerill , who is currently reworking the gap fill algorithm.

That's why I attached that model. Have a look at the same model but now saved as AMF with my settings which should show the problem. At least it does look weird for me with Slic3r 1.14.1:

screenshot from 2018-12-14 20-57-18

supermerill commented 5 years ago

On my fork, coming into slic3rPE next year: thin_ok

lostcontrol commented 5 years ago

@supermerill looks great, looking forward to it :+1: But why do you only have 1 shell? How does it look like with 3 shells?