search

prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.64k stars 1.92k forks source link

Add Color change to layer edit #1533

Closed schneidp20 closed 5 years ago

schneidp20 commented 5 years ago

Version

1.41.2-rc

Use About->About Slic3r for release versions

Operating system type + version

Windows 10

Behavior

A feature suggession to insert color change in the layer edit, rather than have to manually edit the gcode or use prusa's online editor.

I'm a 30+ year C++ programmer. I haven't looked at the code yet, but I'm willing to tackle this if nobody is currently working on it and you accept my suggestion. I

THanks! David

EXOgreen commented 5 years ago

@schneidp20 luckily for you, the 1.42.0-alpha1 has this feature already! I suggest reading this for all the changes, they have a video linked too, the timestamp for color changing is 6:56

lukasmatena commented 5 years ago

As @EXOgreen said, this is already implemented in the latest alpha release. Closing.

schneidp20 commented 5 years ago

Sweet! Thank you!

On Wed, Dec 26, 2018 at 5:27 PM EXOgreen notifications@github.com wrote:

@schneidp20 https://github.com/schneidp20 luckily for you, the 1.42.0-alpha1 has this feature already! I suggest reading this https://github.com/prusa3d/Slic3r/releases/tag/version_1.42.0-alpha1for all the changes, they have a video https://youtu.be/qoAL6zwERg8 linked too, the timestamp for color changing is 6:56 https://youtu.be/qoAL6zwERg8?t=416

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prusa3d/Slic3r/issues/1533#issuecomment-450040672, or mute the thread https://github.com/notifications/unsubscribe-auth/AM3M4epoIlfSqJiH-i9xAA3jIQVk_AYeks5u9AXdgaJpZM4ZiJzO .

schneidp20 commented 5 years ago

I watched the video. Wow, you guys have done a great job. My idea was just to flag the layer in the old UI, but you guys brought it to a much higher level by being able to visualize it. Again, great job!

On Wed, Dec 26, 2018 at 5:27 PM EXOgreen notifications@github.com wrote:

@schneidp20 luckily for you, the 1.42.0-alpha1 has this feature already! I suggest reading this for all the changes, they have a video linked too, the timestamp for color changing is 6:56

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

schneidp20 commented 5 years ago

Sorry to bug you again. I'm sure the Q load is enormous. Did you totally eliminate the old way of viewing the slices? The new 3D view is cool, but it looses the resolution you get with the old view of the slices. I can kind of see what is going on if I view the slices from the bottom, but I also like the old way of viewing the slices. Hopefully it's still there, but I just can't find it.

BTW: Usability wise, it would be nice to have hover-over help for adding color marks and probably other things. I do embedded S/W development and recent years there has been a big focus on human center design for UI. I'd be willing to donate some time to the cause.

On Wed, Dec 26, 2018 at 5:27 PM EXOgreen notifications@github.com wrote:

@schneidp20 https://github.com/schneidp20 luckily for you, the 1.42.0-alpha1 has this feature already! I suggest reading this https://github.com/prusa3d/Slic3r/releases/tag/version_1.42.0-alpha1for all the changes, they have a video https://youtu.be/qoAL6zwERg8 linked too, the timestamp for color changing is 6:56 https://youtu.be/qoAL6zwERg8?t=416

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prusa3d/Slic3r/issues/1533#issuecomment-450040672, or mute the thread https://github.com/notifications/unsubscribe-auth/AM3M4epoIlfSqJiH-i9xAA3jIQVk_AYeks5u9AXdgaJpZM4ZiJzO .

bubnikv commented 5 years ago

We will likely re-implement the old 2d layer view if there is enough of interest for it.

BTW: Usability wise, it would be nice to have hover-over help for adding color marks and probably other things.

Sorry, I am not sure I understand.

I do embedded S/W development and recent years there has been a big focus on human center design for UI. I'd be willing to donate some time to the cause.

Any help is always appreciated.

schneidp20 commented 5 years ago

Re: hover-over. I'm sure you've seen it, I'm probably just using a different term that you use. When you hover the mouse over a button, say the "+" button for color change, a brief little pop-up appears with a little text saying what that button is. If you use Gmail, mouse over the various items on the page and you see what I mean.

Re: Help. Ok, I'll download and compile and let you know when I can tackle something.

On Wed, Jan 2, 2019 at 8:25 AM bubnikv notifications@github.com wrote:

We will likely re-implement the old 2d layer view if there is enough of interest for it.

BTW: Usability wise, it would be nice to have hover-over help for adding color marks and probably other things.

Sorry, I am not sure I understand.

I do embedded S/W development and recent years there has been a big focus on human center design for UI. I'd be willing to donate some time to the cause.

Any help is always appreciated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prusa3d/Slic3r/issues/1533#issuecomment-450875993, or mute the thread https://github.com/notifications/unsubscribe-auth/AM3M4fSoX_rH-pt55HS-HeG30Kk4QyIaks5u_MFbgaJpZM4ZiJzO .

bubnikv commented 5 years ago

I see. We use tooltips at many places.