search

prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.75k stars 1.93k forks source link

Feature Request: Keyboard shortcuts help dialog should not be modal #2322

Open davidhbrown opened 5 years ago

davidhbrown commented 5 years ago

Version

Version 2.0.0+win64

Operating system type + version

Windows 10 Pro, 1809

3D printer brand / version + firmware version (if known)

Irrelevant (but Original Prusa i3 Mk2.5 with firmware 3.7.1)

Behavior

This is a request that an existing feature's behavior should be modified

Project File (.3MF) where problem occurs

No file is needed; this issue is apparent immediately after launching PrusaSlicer.

According to the wxWidgets wxDialog Class Reference changing this behavior might be as easy as changing a call to ShowModal() to Show(). Possible good first issue?

BerndJM commented 5 years ago

As a quick workaround (until maybe it gets fixed): Why not simply take a screenshot from the shortcuts window?

davidhbrown commented 5 years ago

That is a good thought :-) I was having too much fun looking up the wxWidgets docs and trying to begin to understand the project structure to think of that!

bubnikv commented 5 years ago

Sorry, but it works as intended. Keep in mind, that we are building an application not just for geeks, but for beginners as well. You really want to avoid the non-modal dialogs to be usable by a beginner. The beginner certainly does not want to hunt for the windows. It is a better idea IMHO to prepare a cheat sheet with keyboard short cuts to be printed.

On Wed, May 22, 2019 at 6:11 AM David Brown notifications@github.com wrote:

That is a good thought :-) I was having too much fun looking up the wxWidgets docs and trying to begin to understand the project structure to think of that!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/prusa3d/PrusaSlicer/issues/2322?email_source=notifications&email_token=ABMPSI7TJYM54AGZRGQKQADPWTBYHA5CNFSM4HOPUFUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV525XY#issuecomment-494644959, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMPSIZXO3RPLE3XE4NMT5LPWTBYHANCNFSM4HOPUFUA .

davidhbrown commented 5 years ago

I had not heard that "hunt for the windows" concern before; would be interested to read more. I'd been thinking of cautions about when not to use modals such as from Nielsen Normal Group, Google, and Apple. And of course, my own inconvenience in using this help screen. But if this is your intent, you're the developers. If the dialog included a link to such a printable cheat sheet, sure, that would be great... though I do have more room on my monitors than on my desk. Thanks for the reply.

bubnikv commented 5 years ago

We are judging the simplicity for a first time user (imagine your kid or your grandma) versus power for the power users versus the load of our support. Making the feature configurable does not cut it in respect to our support load, as somebody will mess up the setup and then imagine the customer being on a phone line looking at a different screen than the support personnel.

davidhbrown commented 5 years ago

Bubnikv, I appreciate your sharing your understanding and insights. However, I wonder if you might be thinking of a different issue? I didn't suggest making anything configurable. Just that you be able to leave the help visible on screen while continuing to use the program.

Anyway, there are probably better ways to achieve the underlying goal -- for example, MS Office puts help information into a sidebar which is well suited to 16:9 monitors -- but switching from a modal to standard dialog seemed like it would probably be easiest to implement given the decision had already been made to put help information into a dialog.

(Should I close this or you?)

prowlmedia commented 5 years ago

So... the modal pop for the keyboard shortcuts is an issue. it doesn't always open in the foreground and can easily get lost behind other apps. Then you go back to your platter and nothing works. You can't actually use the app and look at the keyboard shortcuts at the same time.

bubnikv commented 5 years ago

it doesn't always open in the foreground

What system? How can I reproduce it?

can easily get lost behind other apps

What system? How can I reproduce it?

Then you go back to your platter and nothing works.

Again, how can I reproduce it?

You can't actually use the app and look at the keyboard shortcuts at the same time.

No, the keyboard shortcuts dialog is modal.

BerndJM commented 5 years ago

You can't actually use the app and look at the keyboard shortcuts at the same time.

No, the keyboard shortcuts dialog is modal.

At least under Linux the modal keeps the focus so you can do nothing in the main window ...

davidhbrown commented 5 years ago

I still think a modal dialog is exactly the wrong choice here for all the reasons mentioned in the links I gave previously (May 22), but under Windows, too, the dialog does keep focus. You can move the dialog away from the main window, even to a different monitor, which could be confusing. But I wasn't able to trick Windows into messing up the stacking order.

prowlmedia commented 5 years ago

No, the keyboard shortcuts dialog is modal.

Exactly.

Mac or PC - a modal help window always a bad idea idea. You can’t explore or use the app at the same time. Open it look for command ( load of which are missing like mirror x / y / z ) then

On mac... What is quite annoying is that I used to be able to use the system MacOS keyboard shortcuts to assign ANYTHING in the menu bar to have my own shortcut.

It’s one of the best things about MacOS - a unified Menu UI that is easily to customise. Now that seems to have been disabled for some reason.