prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.75k stars 1.93k forks source link

Option to disable text replacement on MacOS #5261

Open janis-ax opened 3 years ago

janis-ax commented 3 years ago

Version

2.2.0+

Operating system type + version

Mac OS Big Sur - 11.0.1 (20B29)

Behavior

I have text replacement on my MacBook enabled. So my MacBook replaces 'on' with 'online' and so on. The problem is, that the printer and filament settings have the option customized G-Code and in the text field Start-G-Code my MacBook replaces words like 'on'.

In consequences, during slicing PrusaSlicer throws in error cause the G-Code in these customized sections is wrong.

Is this a new feature request? Yes

bubnikv commented 3 years ago

I would bet we solved that with a wxWidgets patch, but it seems the current wxWidgets we are using has changed.

https://github.com/wxWidgets/wxWidgets/commit/8d42890df49564d6d81e413bcd4428bf6a8b10e6

For reference (and for @yusanka), this is the methods provided by wxWidgets 3.1.3

void wxNSTextViewControl::CheckSpelling(bool check)
{
    if (m_textView)
        [m_textView setContinuousSpellCheckingEnabled: check];
}

void wxNSTextViewControl::EnableAutomaticQuoteSubstitution(bool enable)
{
    if (m_textView)
        [m_textView setAutomaticQuoteSubstitutionEnabled:enable];
}

void wxNSTextViewControl::EnableAutomaticDashSubstitution(bool enable)
{
    if (m_textView)
        [m_textView setAutomaticDashSubstitutionEnabled:enable];
}

st 25. 11. 2020 v 9:50 odesílatel janis-ax notifications@github.com napsal:

Version

2.2.0+ Operating system type + version

Mac OS Big Sur - 11.0.1 (20B29) Behavior

I have text replacement on my MacBook enabled. So my MacBook replaces 'on' with 'online' and so on. The problem is, that the printer and filament settings have the option customized G-Code and in the text field Start-G-Code my MacBook replaces words like 'on'.

In consequences, during slicing PrusaSlicer throws in error cause the G-Code in these customized sections is wrong.

-

Steps needed to reproduce the problem → enable text replacement on MacOS for the word 'la', 'on' or 'min' and the G-Code in theses section change.

Expected Results An option to disable text replacement for PrusaSlicer only or that there is no replacement

Is this a new feature request? Yes

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/prusa3d/PrusaSlicer/issues/5261, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMPSI74K6FPPMTQXD75IU3SRTAOLANCNFSM4UCC4NXQ .

bubnikv commented 3 years ago

Update:

We are already disabling quote substitution and dash substitution. We need likely to call

but for that we would have to patch our wxWidgets.