prusa3d / PrusaSlicer

G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)
https://www.prusa3d.com/prusaslicer/
GNU Affero General Public License v3.0
7.62k stars 1.92k forks source link

gcode viewer - error with CR LF line break type #7790

Open SteWhite opened 2 years ago

SteWhite commented 2 years ago

Version

2.4.0

Operating system type + version

Windows 10 x64

3D printer brand / version + firmware version (if known)

mk3s

Behavior

If I download a gcode from Octoprint with dashboard plugin I've this issue: "Configuration block closing tag "; prusaslicer_config = end" not found when reading xxxx.gcode"

With notepad++ I can see the difference: the dashboard plugin add CRLF at the end on the line. If I replacee CRLF with LF the error disappares.

I've successfully fixed my GCODE files with notepad++

GCODE file where problem occurs:

octoprint_dash.zip

gcode_error notepad++

Jebtrix commented 2 years ago

This is an issue for the Octoprint plugin to fix: https://github.com/j7126/OctoPrint-Dashboard/issues

SteWhite commented 2 years ago

This is an issue for the Octoprint plugin to fix: https://github.com/j7126/OctoPrint-Dashboard/issues

Thanks for the reply but all other software opens that file except prusaslicer. I think it is enough to make a change and consider CRLF as LF.

Jebtrix commented 2 years ago

I would still create an issue on the plugin, mixing EOL is really bad behavior regardless.