prusnak / suez

Tool for pretty printing and optimizing Lightning Network channels.
GNU General Public License v3.0
78 stars 20 forks source link

Confirming: is it dangerous to interrupt the script (e.g., via CTRL+C)? #28

Closed xanoni closed 1 year ago

xanoni commented 3 years ago

https://docs.lightning.engineering/lightning-network-tools/lnd/safety#prevent-data-corruption

The following (non-exhaustive) list of things can lead to data corruption: [...] Aborting channel operation commands (see next chapter). [...]

Next chapter (https://docs.lightning.engineering/lightning-network-tools/lnd/safety#dont-interrupt-lncli-commands):

Things can start to take a while to execute if a node has more than 50 to 100 channels. It is extremely important to never interrupt an lncli command if it is manipulating the channel database, which is true for the following commands: [...] updatechanpolicy [...]

Thus, I assume we should "never interrupt" suez.py?

pira commented 1 year ago

suez.py does not always run updatechanpolicy. in fact it never does unless you do use automated fee setting feature of it.

prusnak commented 1 year ago

Yes, don't break when you modify channel settings.