prusnak / suez

Tool for pretty printing and optimizing Lightning Network channels.
GNU General Public License v3.0
78 stars 20 forks source link

Add arguments to show only public or only private channels #42

Closed lirre8 closed 1 year ago

lirre8 commented 1 year ago

Not sure if this feature makes sense? But I find it very useful to look at public and private channels separately. Could be implemented by adding '--only-public' and '--only-private' arguments and only show channels accordingly.

prusnak commented 1 year ago

Maybe we can add the following option:

--channels={both,public,private,split}

Where both is current behaviour, public shows only public, private shows only private and split shows public first and then private?

Would you like to create a PR with this option?

lirre8 commented 1 year ago

Yes, that would be good. I'll create a PR

lirre8 commented 1 year ago

What do you think about naming it all instead of both? Feels more natural I think to use --channels=all instead of --channels=both

prusnak commented 1 year ago

Sure, all sounds good

lirre8 commented 1 year ago

Created this PR: https://github.com/prusnak/suez/pull/43

Btw, while testing with cln I noticed that there are fields used in the code that are no longer available in the latest version of lightning-cli, msatoshi_total and msatoshi_to_us, and one field that is treated as string in the code but is returned as int, last_tx_fee_msat.

prusnak commented 1 year ago

43 merged

Thanks!