Closed andrehjr closed 3 years ago
Nice one, that indeed unblocks the release.
That said, some of the tests fail on 3.0 :) https://app.circleci.com/pipelines/github/pry/pry-doc/22/workflows/1f25c741-14b6-458a-991a-f1e0e71c9b5b/jobs/160
Here's the PR: https://github.com/pry/pry-doc/pull/109
If that is merged, I will release a new version.
@kyrylo that's odd, this commit is not merged on #109 anymore. (I made this PR on top of #109 / ruby-3-0-testing)
3.0 passed on this build https://app.circleci.com/pipelines/github/pry/pry-doc/21/workflows/67674a42-07b3-41c8-b678-c3603a805ffe 🤔 did you force push after?
Only Ruby 2.0 is failing on that build because of a rexml issue that also needs :eyes: maybe because of https://github.com/ruby/rexml/issues/69
That was the case - a force push. I didn't realize you wanted to merge that with branch ruby-3-0-testing
. I thought it was merged into master
.
I cannot cherry-pick your commit. Not sure how to restore it 😕 Do you mind opening a new PR, maybe?
Done on #117 🙌
Hi there 🙌
I think those specs are failing because Dir.glob is not being found over the C docs yard was generated from.
Investigating why I saw that Dir.glob was moved into
dir.rb
and removed fromdir.c
on the following commit https://github.com/ruby/ruby/commit/60e25e37d4db86249d3c25e03d96875eb98d9e43#diff-7b6c9d59e98b433bac23d954cfeb47fb25e36e93cdad448ffa777612fb52cc52Changing this spec to a method still defined in C would make those specs pass and that could unblock the release?
Ideally for other
$ Dir.glob
and other methods moved for .rb files to work like it was on 2.7 there is a little bit more work. For example, adding those dir.rb and other files do the yardoc generation. I can investigate a bit more. Would that make sense?