search

pry / pry-doc

Provide MRI Core documentation and source code for the Pry REPL
https://github.com/pry/pry-doc
Other
175 stars 26 forks source link

Fixed deprecation warning for pry v0.12.0 #87

Closed sue445 closed 5 years ago

sue445 commented 5 years ago

c.f. https://github.com/pry/pry/blob/master/CHANGELOG.md#v0120-november-5-2018

Now (pry v0.12.0 + pry-doc v0.13.4)

$ bundle exec rspec
/Users/sue445/workspace/github.com/pry/pry-doc/lib/pry-doc/pry_ext/show_source_with_c_internals/ruby_source_installer.rb:28: warning: constant Pry::Platform is deprecated
/Users/sue445/workspace/github.com/pry/pry-doc/lib/pry-doc/pry_ext/show_source_with_c_internals/ruby_source_installer.rb:35: warning: constant Pry::Platform is deprecated

Building Sample Gem with C Extensions for testing..
creating Makefile
compiling sample.c
linking shared-object sample.bundle

Testing pry-doc version 0.13.4...
Ruby version: 2.5.1

Randomized with seed 14933
Scanning and caching *.c files...
......../Users/sue445/workspace/github.com/pry/pry-doc/lib/pry-doc/pry_ext/show_source_with_c_internals/c_file.rb:47: warning: constant Pry::Platform is deprecated
./Users/sue445/workspace/github.com/pry/pry-doc/lib/pry-doc/pry_ext/show_source_with_c_internals/c_file.rb:47: warning: constant Pry::Platform is deprecated
...../Users/sue445/workspace/github.com/pry/pry-doc/lib/pry-doc/pry_ext/show_source_with_c_internals/c_file.rb:47: warning: constant Pry::Platform is deprecated
.../Users/sue445/workspace/github.com/pry/pry-doc/lib/pry-doc/pry_ext/show_source_with_c_internals/c_file.rb:47: warning: constant Pry::Platform is deprecated
...../Users/sue445/workspace/github.com/pry/pry-doc/lib/pry-doc/pry_ext/show_source_with_c_internals/c_file.rb:47: warning: constant Pry::Platform is deprecated
..................

Finished in 0.56493 seconds (files took 3.31 seconds to load)
40 examples, 0 failures

Randomized with seed 14933

After (pry v0.12.0 + pry-doc my branch)

$ bundle exec rspec

Building Sample Gem with C Extensions for testing..
creating Makefile
linking shared-object sample.bundle

Testing pry-doc version 0.13.4...
Ruby version: 2.5.1

Randomized with seed 14605
Scanning and caching *.c files...
........................................

Finished in 0.19723 seconds (files took 0.73212 seconds to load)
40 examples, 0 failures

Randomized with seed 14605

After (pry v0.11.3 + pry-doc my branch)

$ bundle exec rspec

Building Sample Gem with C Extensions for testing..
creating Makefile
linking shared-object sample.bundle

Testing pry-doc version 0.13.4...
Ruby version: 2.5.1

Randomized with seed 3241
Scanning and caching *.c files...
........................................

Finished in 0.1765 seconds (files took 0.56779 seconds to load)
40 examples, 0 failures

Randomized with seed 3241
sue445 commented 5 years ago

https://travis-ci.org/pry/pry-doc/builds/450772228 Test is failed only Ruby 2.0. So I fixed at #88

sue445 commented 5 years ago

I rebased this branch from latest master