pry / pry-stack_explorer

Walk the stack in a Pry session
Other
454 stars 28 forks source link

"warning: _pry_ is deprecated, use pry_instance instead" #45

Closed karlwilbur closed 4 years ago

karlwilbur commented 4 years ago

Getting deprecation warning:

-> % rails c
Loading development environment (Rails 6.0.2.2)
/home/karl/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/pry-stack_explorer-0.4.9.3/lib/pry-stack_explorer.rb:130: warning: _pry_ is deprecated, use pry_instance instead
/home/karl/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/pry-stack_explorer-0.4.9.3/lib/pry-stack_explorer.rb:131: warning: _pry_ is deprecated, use pry_instance instead
/home/karl/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/pry-stack_explorer-0.4.9.3/lib/pry-stack_explorer.rb:132: warning: _pry_ is deprecated, use pry_instance instead

This is also present when running tests for pry-stack_explorer:

-> % rake test
bacon -I test -r rubygems -a -q
Testing pry-stack_explorer version 0.4.9.3...
Ruby version: 2.6.5
/home/karl/Projects/KandR/pry-stack_explorer/lib/pry-stack_explorer/commands.rb:8: warning: _pry_ is deprecated, use pry_instance instead
/home/karl/Projects/KandR/pry-stack_explorer/lib/pry-stack_explorer/commands.rb:8: warning: _pry_ is deprecated, use pry_instance instead
/home/karl/Projects/KandR/pry-stack_explorer/lib/pry-stack_explorer/commands.rb:8: warning: _pry_ is deprecated, use pry_instance instead
...(repeated 230 more times)...

It looks like the simple solution is to replace _pry_ with pry_instance, but I'm not sure how far back this is supported in Pry. I can submit a simple PR for this change.

joallard commented 4 years ago

Fixed 0.5.0