Fixes for Ruby 2.6/2.7 and Pry 0.13

joallard commented 4 years ago

I volunteered some housekeeping, as this is a gem that's essential to me and that I appreciate a lot.

I was noticing a lot of warnings whenever I used:

Tab completion
ls
Some Pry starts

show-stack was also broken as of Pry 0.13, following pry/pry#1865.

A few notes:

My commits are very atomic. If one cares about eg using Ruby 2.5 or Pry 0.12, there is a commit that should get close to there. Everything is fixed in order.
I've fixed some things with the test runner, but I do not understand how tests on the last release pass. I couldn't make Pry.config.history.should_*= work on any Pry version (0.9.11 to 0.13)
This includes @karlwilbur's commit as-is in #46, credit where credit is due. Thanks Karl for getting the ball rolling! (cc #45)

As to leaving 2.5 behind, I figured it was simple to do it this way, and 2.5 users can always use 0.4.9.3. I left them a hint in the Readme if that happens. (2.5 is currently in security maintenance and going EOL in March 2021)

(Edit: Thinking about it, we could probably branch off a version compatible with 2.5 with only cherry-picking the Pry 0.13 fixes - let me know if I can help with that)

I don't understand the test failures, apologies for that. I didn't have the bandwidth to fix them up, unfortunately.

However, I've tested my changes on a real-world Rails app around 10+ times, trying different commands, and I couldn't find a single bug. It should be pretty solid.

The changes are pretty simple, I'm fairly sure there are no regressions introduced.

Paging @kyrylo @banister @ConradIrwin

Not sure how much time you have to dedicate to this,—and as a maintainer of another project I have no time for ;o)—, I'd personally feel pretty fine merging this knowing what I know. This is in my opinion ready to merge, maybe save a few sanity checks/confirmations.

banister commented 4 years ago

Great work :)

I'll merge it, and do you want to be added as maintainer?

It would be good if you can fix the tests, but if you say it works, then that's fine with me. I don't have the bandwidth anymore to work on this sorry.

joallard commented 4 years ago

Yep, happy to do some gardening! Thanks!

banister commented 4 years ago

I added you as maintainer already :) - if you give me your email address i can also give you the power to release gems

banister commented 4 years ago

You can email me your address at redacted@gmail.com

karlwilbur commented 4 years ago

@joallard Thanks!

pry / pry-stack_explorer

Fixes for Ruby 2.6/2.7 and Pry 0.13 #49