pry0cc / axiom

The dynamic infrastructure framework for everybody! Distribute the workload of many different scanning tools with ease, including nmap, ffuf, masscan, nuclei, meg and many more!
MIT License
3.91k stars 615 forks source link

fleet-prefix reuse problem #806

Open TomerSalt opened 1 month ago

TomerSalt commented 1 month ago

whenever using axiom-scan with flags for auto creation of a fleet with static prefix and auto removal as is: axiom-scan -m --fleet scanner --rm-when-done --spinup 5

for the first time it works great, but due to the way aws works with instances termination, if re running this command again the cli will return 2 instances id and break the axiom.


              _
  ____ __  __(_)___  ____ ___        ______________ _____
 / __ `/ |/_/ / __ \/ __ `__ \______/ ___/ ___/ __ `/ __ \
/ /_/ />  </ / /_/ / / / / / /_____(__  ) /__/ /_/ / / / /
\__,_/_/|_/_/\____/_/ /_/ /_/     /____/\___/\__,_/_/ /_/

                                    @pry0cc
                                 & @0xtavian

Spinning up fleet axiom-scanner with 10 instances...
Initializing new fleet 'axiom-scanner' with 10 instances...
INITIALIZING IN 5 SECONDS, CTRL+C to quit... 
Instances: [ axiom-scanner01 axiom-scanner02 axiom-scanner03 axiom-scanner04 axiom-scanner05 axiom-scanner06 axiom-scanner07 axiom-scanner08 axiom-scanner09 axiom-scanner10  ]
Initialized instance 'axiom-scanner01' at 'nullation...
3.*.*.117'!
.
.
.

As can be observed above, the terminated yet to be deleted instances return null and interrupt the expected behavior and crashes the program later on. Subsequently the sshconfig is not properly generated and thus many of the axiom-* cli utils fail to run.

A similiar problem occurs when trying to delete such instance:

(venv) user@MacBook ~ % axiom-rm axiom-scanner\*                
Deleting 'axiom-scanner01'...
i-09f9*****7a2f
i-0b4*****da56

An error occurred (InvalidInstanceID.Malformed) when calling the TerminateInstances operation: The instance ID 'i-09f9*****7a2f
i-0b4*****da56' is malformed
.
.
.

deducted some information with astrixes

coffeegist commented 6 days ago

I'm also seeing this through simply spinning a fleet up, spinning it down manually, and reusing the name within a short time frame