search

prydonius / karn

Manage multiple Git identities
MIT License
304 stars 7 forks source link

Should karn unset local identity if it's missing? #3

Closed prydonius closed 9 years ago

prydonius commented 9 years ago

At the moment, if a repo doesn't have a matching configuration, karn won't touch the local configuration. Should karn unset the local configuration so that in these cases the default/global identity is always used?

e.g.

  1. Set identity in karn.yml
/repo:
  name: Adnan A
  1. Run $ karn update
  2. Remove identity in karn.yml
  3. Run $ karn update

Name is kept as "Adnan A" and not reset back to global/default.

mAAdhaTTah commented 9 years ago

I don't think so, if the user sets the repo config themselves, karn shouldn't unset it on them.

prydonius commented 9 years ago

I guess you're right, it would be good keep karn non-destructive, closing for now.