search

prydonius / karn

Manage multiple Git identities
MIT License
304 stars 7 forks source link

karn 0.1.0 test failure #30

Open chenrui333 opened 3 years ago

chenrui333 commented 3 years ago

👋 trying to build the latest release, but run into some build issue. The error log is as below:

test failure ``` $ /usr/local/Cellar/karn/0.1.0/bin/karn update Couldn't retrieve identity from Git repository. ```

Full build log is in here, https://github.com/Homebrew/homebrew-core/runs/1923367719 relates to https://github.com/Homebrew/homebrew-core/pull/71388

chenrui333 commented 3 years ago

cc @prydonius

prydonius commented 3 years ago

hey @chenrui333, thanks for trying to update the homebrew version! it looks like the logs expired from that link, where can I see the tests being run?

chenrui333 commented 3 years ago

Not a problem, I can reopen the PR and show the latest run log.

chenrui333 commented 3 years ago

@prydonius you should be able to see the new logs in here, https://github.com/Homebrew/homebrew-core/runs/3414407450

prydonius commented 3 years ago

Hey @chenrui333 sorry for the late reply. It looks like its triggering this error https://github.com/prydonius/karn/blob/884cdbe20b0aed1e8f3c4d0df8f76a58a5b72f55/repo/repo.go#L57, which suggests the test isn't running inside a git repo. The test sets up a git repo (runs git init https://github.com/Homebrew/homebrew-core/pull/71388/files#diff-fa51834428472fe94699f5fb82987c355f3897a72e53eef4e1aac42846841d72R29-R32), so I'm not sure why that wouldn't work. Might be worth checking with a Homebrew maintainer about the test environment.