Closed antwan closed 7 years ago
Thanks for the patch, it does pass all tests but it overrides context object and I'm not 100% sure it wouldn't break anything. My concern is that context might have additional keys used for template rendering as so replacing it with a static 2 element dict will make those keys unavailable. A safer approach would be to convert context object to a dict and inject breadcrumb keys. Please take a look at https://github.com/prymitive/bootstrap-breadcrumbs/commit/f2e6b17afa41cf7c7498baa67c09dd85191894bb and if that works for you update this PR. Thanks again.
Given the templates used, even if the context had additional keys (it's actually empty), they wouldn't be used anyway.
I'll update the PR though.
Fixed in 17b8879643ddfff6b5568a7f05b84b27380a8cec
This PR fixes a Django 1.9 warning when rendering template using a RequestContext instead of a dict. As per the [deprecation plan](https://docs.djangoproject.com/en/1.9/_modules/django/template/backends/django/|deprecation plan) since 1.8, it is recommanded to send a dictionnary
context
instead of aContext
orRequestContext
object when rendering templates. A warning is raised on Django 1.9, but it won't (immediately) break on Django 1.10 thus making a future error silent.Tested with Django 1.5 to 1.10.