search

prymitive / bootstrap-breadcrumbs

Django template tags for easy breadcrumbs using twitter bootstrap css classes or custom template
django-bootstrap-breadcrumbs.readthedocs.org
MIT License
92 stars 47 forks source link

smart_text() is deprecated in favor of smart_str() #64

Open sde1000 opened 4 years ago

sde1000 commented 4 years ago

Using django-bootstrap-breadcrumbs 0.9.2 with Django 3.0.7, I get the following deprecation warning:

lib/python3.8/site-packages/django_bootstrap_breadcrumbs/templatetags/django_bootstrap_breadcrumbs.py:151: RemovedInDjango40Warning: smart_text() is deprecated in favor of smart_str().
  links.append((url, smart_text(label) if label else label))

Checking the Django source it looks like smart_text() is now just a call to smart_str().

sde1000 commented 4 years ago

(It looks like I mentioned this in #60 but only the first of the two warnings got fixed.)

richardbrockie commented 2 years ago

Is this merge going to occur - it's been pending for almost 2 years...?

christianwgd commented 2 years ago

And now it breaks Dango 4.0 compatibility, since smart_text was removed. Would be great to see this merged and released.