pryorda / vmware_exporter

VMWare vCenter Exporter for Prometheus
BSD 3-Clause "New" or "Revised" License
523 stars 200 forks source link

Enhancement: VM Resource Pool Label #224

Open gtowsey opened 4 years ago

gtowsey commented 4 years ago

As an enhancement would it be possible to add a label to VM for its current resource pool.

In a multi tenanted world the resource pool forms a logical grouping for us.

My understanding from reading through the code is resource pool is already a property of vim.virtualmachine

pyvmomi vim.virtualmachine

so this enhancement would include the addition of a label and resource pool added to properties. Similar datastore would be a really handy label although can fluctuate a little more than wanted.

i appreciate there is probably an infinite list of labels people want but this would certainly make my life easier.

An additional future feature request may be to collect metrics about the resource pools in particular cpu/memory limit and reservation

RyanW8 commented 2 years ago

This would be great if this could be implemented

thuvh commented 2 years ago

I think resource pool is a tree, what should we display it?