search

prysmaticlabs / prysm

Go implementation of Ethereum proof of stake
https://www.offchainlabs.com
GNU General Public License v3.0
3.46k stars 985 forks source link

Move from *ethpb.Checkpoint to *forkchoicetypes.Checkpoint #10901

Open potuz opened 2 years ago

potuz commented 2 years ago

In several areas of our code we use []byte for roots when [32]byte would be more efficient. The main reason for this is protobuf support. Forkchoice uses internally [32]byte and in the interface with blockchain package it needs to convert from []byte. This issue should be marked as solved when all calls from the blockchain package to save/read checkpoints to/from db are switched to use [32]byte so as to avoid copying a checkpoint from a BeaconState.

nisdas commented 1 year ago

This has already been implemented, so closing it.

potuz commented 1 year ago

I don't think was addressed really, I see a lot of slices still.