Deprecate Deposit Contract in Solidity and Use Vyper

prysmaticlabs / prysm

Go implementation of Ethereum proof of stake

https://www.offchainlabs.com

GNU General Public License v3.0

3.46k stars 985 forks source link

Deprecate Deposit Contract in Solidity and Use Vyper #1318

Closed terencechain closed 5 years ago

terencechain commented 5 years ago

There will only be one PoW deposit contract in production and pinpoint to one now will help the community to discover bugs in the early phases. I don't think there's any reason for us to use our own deposit contract in Solidity, and since we can generate bindings from the ABI & bytecode for the vyper contract (see: https://vyper.readthedocs.io/en/latest/compiling-a-contract.html). We should be using the vyper contract as specified in the ETH2.0 spec.

High-level summaries of todo:

Remove any reference to solidity contract
Generate binding for vyper contract
Use vypper contract binding across pyrsm

kushagrasharma commented 5 years ago

I'd be happy to help on this!

terencechain commented 5 years ago

Sure. Thanks @kushagrasharma! Let me know if you have any questions. This can be done via multiple PRs

prestonvanloon commented 5 years ago

@kushagrasharma please outline your plan for this. This is a non-trivial change.

Open questions:

Can we leverage bazel tooling to generate the gobindings at build time?
What tooling do we need to introduce to our continuous integration pipeline? We have solidity linter, is there something similar for Vyper?

nisdas commented 5 years ago

@kushagrasharma , Hey thanks for helping this out with this, however this is an important issue and is blocking our other work, so I will be taking this issue up. You are welcome to try out our other open issues !

kushagrasharma commented 5 years ago

No worries! Sorry about the delay.

rauljordan commented 5 years ago

Closed by #1343