prysmaticlabs / prysm

Go implementation of Ethereum proof of stake
https://www.offchainlabs.com
GNU General Public License v3.0
3.45k stars 986 forks source link

Incompatible with k8s.io/client-go@v0.27.0+ #13958

Closed gg718 closed 3 days ago

gg718 commented 4 months ago

One of my other dependencies pulled in a transient update of k8s.io/client-go and my code started to fail to compile with the following error:

github.com/prysmaticlabs/prysm/v5@v5.0.3/beacon-chain/cache/common.go:10:23: cannot use popProcessNoopFunc (value of type func(_ interface{}) error) as "k8s.io/client-go/tools/cache".PopProcessFunc value in argument to queue.Pop

Would it be possible to fix this incompatibility?

prestonvanloon commented 4 months ago

Please send a PR to update that dependency and we will review it. Thanks

shyam-patel-kira commented 2 months ago

Hi @gg718 , do you have any version in mind for this update?

gg718 commented 3 weeks ago

@shyam-patel-kira The latest (v0.30.4) should be fine.