search

prysmaticlabs / prysm

Go implementation of Ethereum proof of stake
https://www.offchainlabs.com
GNU General Public License v3.0
3.48k stars 1.03k forks source link

P2P Service Test TestBroadcast Needs to Test Round Trip Broadcasting #543

Closed prestonvanloon closed 5 years ago

prestonvanloon commented 6 years ago

Write/improve test for TestBroadcast such that a broadcast is tested to be received by a p2p peer. This involves looking into the libp2p library to determine how to appropriately create hosts in memory for a full test of our broadcast p2p logic.

See: https://github.com/prysmaticlabs/prysm/blob/master/shared/p2p/service_test.go

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Community Fund via ECF Web 3.0 Infrastructure Fund fund.

PumpkingWok commented 6 years ago

Hi @prestonvanloon, Is this issue still open ? I would like to look in it if nobody is working on it. Thanks.

terencechain commented 6 years ago

@PumpkingWok I believe this is still open

frankchen07 commented 6 years ago

@PumpkingWok - don't forget to apply for work on the Gitcoin Issue Details page if you're interested!

mkosowsk commented 6 years ago

@PumpkingWok you are approved to start work :)

gitcoinbot commented 6 years ago

@PumpkingWok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@PumpkingWok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

PumpkingWok commented 6 years ago

Hi, I'm going to start the work tomorrow. I did not understand well if my proposal to this issue had been approved because it does not appear in its gitcoin bounty page. Thanks.

spm32 commented 6 years ago

Hey @PumpkingWok, noted, we'll try to improve the UX on that, glad you're able to get started!

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

PumpkingWok commented 6 years ago

Hi, Yes, i'm still working on this issue.I'm going to init the code test tomorrow. I will keep update this page. Thanks.

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

spm32 commented 6 years ago

Hey @PumpkingWok how's everything going here? Just snoozed the bot :)

PumpkingWok commented 6 years ago

Hi @ceresstation, I'm looking into the code in these days and i would open a PR in few days. can i ask to you in case of help/suggestions ? Thanks in advance.

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

PumpkingWok commented 5 years ago

Hi there, Yes i'm still working in it, i hope to open a PR in very few days. Thanks in advance and sorry for the late reply.

gitcoinbot commented 5 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@pumpkingwok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

prestonvanloon commented 5 years ago

@PumpkingWok do you plan on working on this? We anticipated this issue to take less than one hour for someone familiar with libp2p or someone resourceful with go testing/debugging.

PumpkingWok commented 5 years ago

Hi preston, I’m so sorry for the late reply and for all the times that i’m taking this easy issue. i’m going to open a PR tomorrow if for you it could be ok.sorry again.

PumpkingWok commented 5 years ago

Hi @prestonvanloon, I'm looking into the code and libp2p and try to doing some tests, I should look in it for another day. If you want i can leave the issue, the time that i'm spending in it is very useful for me in any case. I'm so sorry for have been taking this issue since many days. I was very busy and i had no time to look in it deeply, it is my fault. Sorry again.

PumpkingWok commented 5 years ago

Hi preston, I’m going to leave the issue, sorry again but i have really no time. I don’t want that you wait another time. Have a nice day !!

PixelantDesign commented 5 years ago

Hi @prestonvanloon I'll help remarket this issue.

prestonvanloon commented 5 years ago

No problem @pumpkingwok.

Thanks @pixelantdesign!

jgimeno commented 5 years ago

I would like to take this one, but let me take a look so I know how to proceed before assigning it to me.

jgimeno commented 5 years ago

Can we unblock the GitCoin issue? I cannot work on it through gitcoin!

frankchen07 commented 5 years ago

@jgimeno - Frank from Gitcoin here - sorry about that! It seemed like there was an admin override on that status. It's back to open!

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

  1. @jgimeno

@mkosowsk please take a look at the submitted work:

jgimeno commented 5 years ago

@frankchen07 this has been finally merged, do you know how it works to get the bounty? :D

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @jgimeno.

frankchen07 commented 5 years ago

^ looks like @mkosowsk completed payment @jgimeno - let us know if you didn't receive that!

prestonvanloon commented 5 years ago

Unfortunately, we had to revert these changes due to high flakiness and consistent failures on some systems. #1348

jgimeno commented 5 years ago

Oh! I will take a look, probably is related to the timeout very tight.

rauljordan commented 5 years ago

Resolved by our latest p2p package with design doc: https://docs.google.com/document/d/1VyhobQRkEjEkEPxmmdWvaHfKWn0j6dEae_wLZlrFtfU/edit#