prysmaticlabs / prysm

Go implementation of Ethereum proof of stake

https://www.offchainlabs.com

GNU General Public License v3.0

3.47k stars 1.01k forks source link

Roughtime reports clock offset by 4hrs #6825

Closed xuyenvuong closed 4 years ago

xuyenvuong commented 4 years ago

🐞 Bug Report

Description

Slasher was up and running on Medalla and encountered the below error. I have pinged cc: @nisdas @prestonvanloon ### Has this worked before in a previous version? Yes, the previous version in which this bug was not present was: alpha.16 ## 🔬 Minimal Reproduction

🔥 Error



time="2020-07-31 07:12:34" level=warning msg="Roughtime reports your clock is off by more than 2 seconds" offset=4h0m0.317286608s prefix=roughtime

🌍 Your Environment

Operating System:

  

Distributor ID: Ubuntu
Description:    Ubuntu 20.04.1 LTS
Release:        20.04
Codename:       focal

ARM64 on Pi 4 8GB

What version of Prysm are you running? (Which release)

  
alpha.17

Anything else relevant (validator index / public key)?

terencechain commented 4 years ago

Should be addressed by #6879

terencechain commented 4 years ago

This applies to beacon node and validator client as well. We also just observed this again in latest master. This may have been to reason why validators are proposing attestations and beacon blocks in the future

rauljordan commented 4 years ago

Has since been resolved https://docs.google.com/document/d/11RmitNRui10LcLCyoXY6B1INCZZKq30gEU6BEg3EWfk/edit#

xuyenvuong commented 4 years ago

Thanks.

shawnz commented 3 years ago

Sorry if this is the incorrect place for this comment. But shouldn't the roughtime system be taking the median and not the average?

The same suggestion was made here https://github.com/cloudflare/roughtime/issues/22

nisdas commented 3 years ago

Hey @shawnz ,

We do not currently use roughtime anymore, it has been removed in this PR #7299 . As far as I am aware roughtime still takes the average of all responses rather than the median, but given the roughtime spec is still in progress and undergoing standardization this may change in the future.