search

przemoc / metastore

Store and restore metadata from a filesystem.
http://software.przemoc.net/#metastore
GNU General Public License v2.0
169 stars 31 forks source link

Add support for OpenBSD. #43

Closed cryptorick closed 6 years ago

cryptorick commented 7 years ago

These changes allow metastore to build on OpenBSD 6.0 (the latest version as of this date). OpenBSD, as of version 3.8, does not appear to support extended file attributes. Hence for OpenBSD, the code pertaining to this is #ifdefed out here.

cryptorick commented 7 years ago

Hi. I think everything is correct with these changes; however, I'm not so familar with metastore as to have been able to develop a good test to run. I only ran

They seemed to work correctly, especially the --dump which I could eyeball. Thanks for your consideration!

przemoc commented 7 years ago

Thank you for your contribution, @cryptorick. Please read first 2 paragraphs of my comment on other issue.

But I may consider adding define (perhaps NO_XATTR) for building metastore w/o xattr support (reading/dumping metastore file with xattr entries must remain working, though, even if they cannot be applied), because making metastore more modular is a bit more work than I'm willing to spend on soon (well, it should be done in the end anyway).

Only after introducing such general define, I would extend Makefile to set this flag when building for OpenBSD, if it really doesn't support xattr at all (which seems kind of strange if other BSDs support them one way or another).

przemoc commented 6 years ago

Commit 39c5a5e929ef introduced support for NO_XATTR at code level and commit c7e0264a71d3 introduced support for NO_XATTR at Makefile level.

Iff OpenBSD has no support for extended attributes (provide some proof), then please create new commit using NO_XATTR in new openbsd-support branch on top of current master and send it in pull request. Thanks.