Support building on macOS

przemoc / metastore

Store and restore metadata from a filesystem.

http://software.przemoc.net/#metastore

GNU General Public License v2.0

169 stars 31 forks source link

Support building on macOS #48

Open mpctx opened 5 years ago

mpctx commented 5 years ago

Wrap stat and xattr in ifdef directives.
Remove -Bstatic and -Bdynamic arguments in Makefile because the arguments aren't needed and break linking.

Tested on Linux Mint and macOS High Sierra.

mohammad-akhlaghi commented 5 years ago

Thanks a lot "mpctx", I just also tested this commit on several Linux systems and a Mac system and it worked nicely. I just merged it into my own fork of metastore (https://gitlab.com/makhlaghi/metastore-fork), combining it with some minor issues I had to fix. I will be using this fork until the new pull requests implemented in the main project.

przemoc commented 3 years ago

Thank you, @mpctx, for your metastore contribution.

As it is right now, it's rather a no-go, as adding more #ifdef spaghetti code is undesirable and not maintainable. We have to introduce OS-agnostic API internally and provide OS-specific implementation if common denominator cannot be easily found.