4 bugs, 1 glitch, 2 improvements

[KostromDan]

1. If we will press S and keyup keys together, S erlier, mod wouldnt realese that keyup pressed. Also works with W and keyup, W and keydown, S and keydown. Not only at ground on flight too.

https://user-images.githubusercontent.com/90044015/197353733-5c97b741-ae5f-4d0d-b810-43e0ca3bd441.mp4

2. If we will put the engine on maximum, leave plane, spawn new plane, the new plane will have also the engine on maximum without pressing any keys. Also applies to inventory, if there were fireballs in the cannon, then they will appear in the new one, although there will be no cannon.

https://user-images.githubusercontent.com/90044015/197353714-06adc4d0-6b29-4c30-824d-00a89abb26d8.mp4

3. Not a bug, but for me as an airplane simulator player, I really liked the new control mechanics, but I really lack the yaw axis. You can, for example, assign to the right-to-left arrows, it would be very convenient.

[KostromDan]

I would also really like to see the artificial restrictions of the helicopter angles removed. It would make it more realistic.https://www.youtube.com/watch?v=vvRWjNRk6T0

[KostromDan]

Also found this bug. Incorrect behavior of the aircraft, it skids under certain circumstances. https://www.youtube.com/watch?v=dCv_-U4RHWo

[KostromDan]

Found incompatibility with CGM. The grenade launcher shells are not flying in the direction of the launch, but somewhere else. https://www.youtube.com/watch?v=zG7SUnF0oaw

[KostromDan]

I found a glitch of a very easy vertical landing. In real life, this is impossible, the plane would have crashed. It lies in the fact that if you turn on the motor right before the crash, at least by 1 division, the plane will not explode, although it flies into the ground with a enormous vertical speed. https://www.youtube.com/watch?v=gOL4ge8gENg

[przemykomo]

Found incompatibility with CGM. The grenade launcher shells are not flying in the direction of the launch, but somewhere else. https://www.youtube.com/watch?v=zG7SUnF0oaw

It's basically impossible to fix without adding a corner case in CGM itself (and every other mod which uses player rotation in some way) since the visible 3D rotation inside of aircraft does not correspond to the normal pitch/yaw rotation.

[KostromDan]

Found incompatibility with CGM. The grenade launcher shells are not flying in the direction of the launch, but somewhere else. https://www.youtube.com/watch?v=zG7SUnF0oaw

It's basically impossible to fix without adding a corner case in CGM itself (and every other mod which uses player rotation in some way) since the visible 3D rotation inside of aircraft does not correspond to the normal pitch/yaw rotation.

On 1.18.2 works fine (tested just now). the bug exists since new mechanics of flight added. I also forgot to say that in the latest version of the mod for 1.19.2, the bug is present only from the first person, from the third it works fine. upd: Also, I have just determined on what principle the bug works. The problem in the direction of the camera is from the mod's side. If you switch to a third person, the direction of view will change dramatically, just in the direction of the projectile's flight. In other words, the mod does not correctly work out switching the view from the first to the third person when turning the aircraft. It also revealed another problem, which I demonstrated in the video. https://www.youtube.com/watch?v=UB9KY-Or4m0

[KostromDan]

Idea: I liked the idea of a sight for an airplane if a gun is installed. It wouldn't be bad to add on a helicopter too. In addition, if you want to do it cool, you can make the sight a separate module. Who wants a nice view, does not install. Who wants to aim accurately, installs.

[KostromDan]

Demonstrated in the video how I see how to make the controls realistic, without conflicts with the minecraft keys and most importantly convenient. In an airplane, only add the yaw axis to keyup, keydown. Otherwise, everything is just a masterpiece after the mechanic update. https://youtu.be/FVEgGTtyKKA On a helicopter, everything is like in the video, only the game that I used for demonstration does not involve adjusting the engine speed, in fashion I would leave it as it is with the help of the keyup keydown arrows, and the angle of attack of the blades would be adjusted with. space and leftctrl. Then everything will be convenient, realistic and without workarounds. https://youtu.be/-of8CLrsalE

[KostromDan]

Idea: Add more types of weapons. In the video, i demonstrated what can be done with standard fireball and tnt. In combination with a macro. In my opinion it looks very cool. What do I suggest: 1) Add a minigun, the functionality is the same as that of a simple gun, but you can clamp and shoot very quickly as in the video. 2) I don't know how easy it is to implement, but I think using OOP, just launching the event of a shot is easy, to add compatibility with CGM projectiles. As I see it: We add 2 slots for guns, 2 slots for ammunition, and just a virtual player shoots in the direction of flight, it's not too difficult to implement. But how impressive it will look, a plane shooting straight-flying missiles. https://www.youtube.com/watch?v=RC5Ou26beNs

I think on this message my ideas for improving the mod have been exhausted so far, I will be glad if at least something can be implemented.

[przemykomo]

2. I don't know how easy it is to implement, but I think using OOP, just launching the event of a shot is easy, to add compatibility with CGM projectiles. As I see it: We add 2 slots for guns, 2 slots for ammunition, and just a virtual player shoots in the direction of flight, it's not too difficult to implement. But how impressive it will look, a plane shooting straight-flying missiles. https://www.youtube.com/watch?v=RC5Ou26beNs

You can already use CGM ammo with the shooter upgrade.

[KostromDan]

2. I don't know how easy it is to implement, but I think using OOP, just launching the event of a shot is easy, to add compatibility with CGM projectiles. As I see it: We add 2 slots for guns, 2 slots for ammunition, and just a virtual player shoots in the direction of flight, it's not too difficult to implement. But how impressive it will look, a plane shooting straight-flying missiles. https://www.youtube.com/watch?v=RC5Ou26beNs

You can already use CGM ammo with the shooter upgrade.

Oh, I checked it out, very cool. It would be even cooler if a couple of types of weapons were installed. For example, to make, say, 3 slots for weapons and give the opportunity to switch between them by some key. Or in the settings, give the opportunity to assign your own key for each slot.

[KostromDan]

An interesting idea came up to add the ability in the config to prohibit access to inventory while the plane is in the air, this would add an element of hardcore and realism, the option is clearly not for everyone, but it would be useful to many modpack creators.

[KostromDan]

1. Add a minigun, the functionality is the same as that of a simple gun, but you can clamp and shoot very quickly as in the video.

If you decide to implement this idea, it would be nice to give the opportunity to shove a shalker with shells into the weapon slots, otherwise the ammunition will quickly run out in survival mode. But this idea is even good as an independent one.

[KostromDan]

It would be nice to add a slot for an energy cell from other mods, it should be charged at a charging station or from a solar panel together with the main energy cell. And in general, it's strange that the power cell is built into the motor itself, it would be cooler if it worked like this: when a player puts an electric motor on an airplane, a battery slot appears in the inventory, and let the mod itself have a simple battery, and the player puts either it or from other mods, for example mekanism.