przemykomo / simple-planes

Planes mod for minecraft forge.
GNU Lesser General Public License v3.0
27 stars 26 forks source link

Modded Water Detection #158

Closed rhino1998 closed 1 year ago

rhino1998 commented 1 year ago

Planes do not detect some modded fluids properly. For instance, TerraFirmaCraft flowing water and salt water are both not recognized properly causing planes to not float on their surface or be impeded by the fluid at all. It is possible to fly a plane through a TFC ocean.

It looks like the following checks are looking specifically for vanilla minecraft water rather than general fluids. https://github.com/przemykomo/simple-planes/blob/9581a6160cfc5566c9a394eb4f952830083e7436/src/main/java/xyz/przemyk/simpleplanes/upgrades/floating/FloatingUpgrade.java#L26 https://github.com/przemykomo/simple-planes/blob/9581a6160cfc5566c9a394eb4f952830083e7436/src/main/java/xyz/przemyk/simpleplanes/entities/PlaneEntity.java#L994-L996