search

przeor / react-router-flux-starter-kit

Why & How to Learn React Redux, the right highly scalable way.
626 stars 84 forks source link

Login.attemptedTransition assigned but never used #8

Closed greenlaw110 closed 9 years ago

greenlaw110 commented 9 years ago

In AuthenticationMixin.js it assigned transition to Login.attemptedTransition static field: image

However that static field is never used in the application. My hypothesis is it should be used in components/auth/login.js::componentDidUpdate: image

Instead of direct the route to /dashboard, it shall check the attemptedTransition state and redirect to there if it's not null.

przeor commented 9 years ago

@greenlaw110 thanks. if you will do a pull request, then I will merge it. I see you already have fixed this part here: https://github.com/greenlaw110/react-router-flux-starter-kit/commit/f02f05dcf7343a14108557170a7d84fb2b87ec83#diff-74fd7423691685207bf4b7a5e58e5b2cR17

przeor commented 9 years ago

merged