ps-actions-sandbox / ActionFundamentals-Zeiss2

MIT License
0 stars 1 forks source link

🔍 Retro Day two: What can be improved? #7

Open github-actions[bot] opened 8 months ago

github-actions[bot] commented 8 months ago

What can be improved? What was missing? Any additional comments? Comment below 👇

ghost commented 8 months ago

Thanks for the training. I’ve only some small points.

sswart commented 8 months ago

Thanks for the training. I’ve only some small points.

  • Sometimes you speak very fast, which is not easy for non-native or not so skilled participants. (But most of the time it’s fine)
  • 03-Staged-deployments.md

    “Add a input of the type environment to the workflow_dispatch trigger.”

    I am not so familiar with GitHub. Therefore, I searched for a place (Button, section, etc.) for the triggers. Maybe a small remainder that the triggers are predefined can be helpful) Also, you don’t mention in which file we should add this. I was confused because multiple files in the “workflows” directory contains this trigger.

Thank you for the feedback! Will definitely consider the speed at which I speak more in the future!

We will try to clarify the HOL to be more specific so that future participants don't run into the same confusion