ps-dps / KeepSomeInventory

Don't lose your equipment when dying
https://modrinth.com/datapack/keep-some-inventory
MIT License
5 stars 2 forks source link

the mod is broken? #15

Closed DiamondBor closed 4 months ago

DiamondBor commented 4 months ago

I'm using the 1.20.6 version of the mod. I died and lost everything except my fireworks; my tools, weapons, armor, & food weren't dropped where I died. All my fighting equipment was just removed from the world, not dropped, or put in my inventory.

PuckiSilver commented 4 months ago

Are your playing in singleplayer or multiplayer? Do you have other mods/plugins/data packs installed?

The pack never touches the items that should be kept at all, it internally uses the "KeepInventory" gamerule and only removes the items that should be dropped, so the equipment meant to be kept never leaves your inventory.

DiamondBor commented 4 months ago

I'm using singleplayer, and I am using some other mods that add new content but don't modify any vanilla items, at least not any that I had in my inventory / items dropped on death

Here's how my inventory looked after I got my items back, image

When I respawned, I only had my fireworks, the water buckets, the ender pearls, the stack of arrows, and i think? my food.

PuckiSilver commented 4 months ago

So you kept some items but not all of the ones you were supposed to? But items still dropped where you died, just not all? That’s even more strange..

Can you tell me the items that behaved weirdly? Then I may be able to reproduce this in vanilla minecraft - but if this is just an incompatibility with a mod, I’m sorry but I won’t be fixing that then, many mods introduce incompatibilities and as a data pack developer it’s impossible to react to all of them.

DiamondBor commented 4 months ago

I had an elytra and a set of diamond armor equipped (except for the chestplate which was in my inventory), a mace, a trident, a bow, and a diamond sword, axe, pickaxe, and shovel.

I don't remember having any more items, but I may have had some more.

It was raining, I used my trident to go up into the air, and tried to hit a pillager with my mace. I missed and that's how I died, in case that helps.

PuckiSilver commented 4 months ago

I’ll see if I can re-create that in vanilla somehow - thanks for letting me know

PuckiSilver commented 4 months ago

I can not reproduce this:

Inventory before death image

Dropped items on ground image

Inventory after collecting items image

As I said, the pack never clears items that are not supposed to be cleared. This is most likely an incompatibility with other mods you have installed, this is not an issue with KeepSomeInventory and will therefore not be fixed, thanks for the report though!

PuckiSilver commented 4 months ago

Sorry, I was hasty, the bug was with enchanted items, it's been fixed in v1.4.2 and onward, sorry for the lost items and general inconvenience