search

ps-wow / Adibags_ByExpansion

Groups items by their expansion.
The Unlicense
5 stars 8 forks source link

Missing mining items #4

Closed vely-digital closed 4 years ago

vely-digital commented 5 years ago

It seems like some mining materials are not in that expansion trade materials(cobalt, saronite, etc). Could I pull this and commit something you are missing in new branch and then push it here?

davidcraig commented 5 years ago

Absolutely, there are lots of missing items, this is something that takes a long time to build up, and I only started doing this at the end of legion, so there's lots to catch up with.

vely-digital commented 5 years ago

Nice! So as I use this addon alot, I'll start updating it when I find something that bothers me.

vely-digital commented 5 years ago

I cloned repo and made new branch. I added gathering professions and some tailoring ones to your code. Could I get Permission to upload that branch to git? Then I'll make pull request and you can check code with your PHP scripts. I'll add more like jewelry and stuff while playing.

davidcraig commented 5 years ago

You should have access now, let me know if you have any issues/questions :)

davidcraig commented 4 years ago

Closing old issue