search

ps2dev / gsKit

gsKit is a C interface to the PS2 Graphics Synthesizer
Other
107 stars 28 forks source link

Various fixes for new toolchain #33

Closed uyjulian closed 4 years ago

rickgaiser commented 4 years ago

Commit 912b019 looks good to me.

Commit e8d8e2c : If the toolchain provides the proper crt0.o file, we don't need to manually override these settings in all our ps2 makefiles. crt0.o is generated from crt0.S and should be in newlib, not in ps2sdk.

It's actually already in newlib, but it's never been updated while the version in ps2sdk is. For the newlib port I've moved crt0.S from ps2sdk to newlib. Commit here: https://gitlab.com/ps2max/toolchain/newlib/-/commit/39fd2f043b9b349db5aaf438fc277474577e7242 Perhaps you can use this approach in your new toolchain as well?

uyjulian commented 4 years ago

For the time being, the new toolchain is based on upstream. I plan to rebase to newlib port later.

uyjulian commented 4 years ago

Rebased and dropped the Makefile changes.

rickgaiser commented 4 years ago

Perfect, thanks. Merging.

AKuHAK commented 4 years ago

Probably issue #24 can be closed as well?