search

ps2dev / gsKit

gsKit is a C interface to the PS2 Graphics Synthesizer
Other
107 stars 28 forks source link

New samll commit #4

Closed AKuHAK closed 8 years ago

AKuHAK commented 8 years ago

Now install target can be called without calling all target first. Added DESTDIR. Small fixes in text files Warnings fixed. These issue can be closed

sp193 commented 8 years ago

Everything else looks good, but what's with the addition of "Wno-unused"? Can't those warnings be fixed the right way around? After all, we desire efficiency. I added that option to some projects like the LWIP ports, but only because I didn't want to fix the warnings in external projects.

sp193 commented 8 years ago

BTW, this pull request is fine, no need to make any changes. I would just like to know why it's necessary, in case there is actually a good reason why the unused variables cannot be removed. It'll save everyone time.

AKuHAK commented 8 years ago

Oh there is already -Wno-unused in gstoolkit and dma sub projects. Only gsKit itself lacks this option. I just assumed that it is safe to add it cause all unused variables in most common cases are used in printf output (in fact I dont know why gcc thinks that it is mean "unused")

sp193 commented 8 years ago

Okay, thanks. I'll take a look at it, when time permits.