search

ps2dev / gsKit

gsKit is a C interface to the PS2 Graphics Synthesizer
Other
107 stars 28 forks source link

Remove HAVE_LIBJPEG, HAVE_LIBPNG and HAVE_LIBTIFF. #81

Closed Wolf3s closed 4 months ago

fjtrujy commented 5 months ago

I'm not 100% if we sure remove it... so far gskit was thought to be built without any other further dependency besides ps2sdk, however, now given the current toolchain workflow installation always happens after installing libpng and so on, this is why CI still passes it.

I think that probably the best is to generate additional gskit libraries which provide functionality for jpeg, png and libtiff. What do you think @rickgaiser ?

Wolf3s commented 5 months ago

I'm not 100% if we sure remove it... so far gskit was thought to be built without any other further dependency besides ps2sdk, however, now given the current toolchain workflow installation always happens after installing libpng and so on, this is why CI still passes it.

I think that probably the best is to generate additional gskit libraries which provide functionality for jpeg, png and libtiff. What do you think @rickgaiser ?

You mean remove all the libraries and add a implementation from scratch for jpg, ttf and tiff? If Yes i would like to see that.

fjtrujy commented 5 months ago

I'm not 100% if we sure remove it... so far gskit was thought to be built without any other further dependency besides ps2sdk, however, now given the current toolchain workflow installation always happens after installing libpng and so on, this is why CI still passes it. I think that probably the best is to generate additional gskit libraries which provide functionality for jpeg, png and libtiff. What do you think @rickgaiser ?

You mean remove all the libraries and add a implementation from scratch for jpg, ttf and tiff? If Yes i would like to see that.

No, I mean to create separate gsKit libraries adding that functionality, like gskit_jpg, gskit_png…

uyjulian commented 5 months ago

I think it would be better to have functions in separate compilation units to enable and register the function for the specific image format. So if you don't use those functions you don't need to link the library

Wolf3s commented 5 months ago

I'm not 100% if we sure remove it... so far gskit was thought to be built without any other further dependency besides ps2sdk, however, now given the current toolchain workflow installation always happens after installing libpng and so on, this is why CI still passes it. I think that probably the best is to generate additional gskit libraries which provide functionality for jpeg, png and libtiff. What do you think @rickgaiser ?

You mean remove all the libraries and add a implementation from scratch for jpg, ttf and tiff? If Yes i would like to see that.

No, I mean to create separate gsKit libraries adding that functionality, like gskit_jpg, gskit_png…

I aprove that, since gsKit wasn't made for that purpose.

Wolf3s commented 4 months ago

Moving on a another request