search

ps2dev / ps2-packer

Create packed ELF files to run on the PS2
GNU General Public License v2.0
72 stars 28 forks source link

Add $DESTDIR in makefile install rules #6

Closed sl1pkn07 closed 6 years ago

sl1pkn07 commented 10 years ago

Hi

attach the patch to add $(DESTDIR) in Makefile install section

(for helper package maintainers)

http://sl1pkn07.no-ip.com/paste/view/5196c905

greetings

sp193 commented 6 years ago

This is old, but I have only just figured out what this is about. Can you elaborate why you couldn't just change the PREFIX variable? If it is desirable to allow PREFIX to be changed externally, we could perhaps make it conditional:

PREFIX ?= $(PS2DEV)
sl1pkn07 commented 6 years ago

https://www.gnu.org/prep/standards/html_node/DESTDIR.html https://stackoverflow.com/questions/11307465/destdir-and-prefix-of-make

sp193 commented 6 years ago

I see. I don't think there is any harm in doing this. Can you make a pull request? You may have to update your patch, as I have updated the Makefile recently.

sp193 commented 6 years ago

Completed in c6e8c38.