ps2dev / ps2sdk-ports

Ports of useful libraries to PS2SDK
Other
107 stars 43 forks source link

Add Fluidsynth support to the PS2. #139

Open 7dog123 opened 7 months ago

7dog123 commented 7 months ago

Using my forked version of https://github.com/DominusExult/fluidsynth-sans-glib/tree/sans_glib which removes glib support from fluidsynth with a little sloppy modification to add PS2 Support while adding a patch from https://github.com/VolcanoMobile/fluidsynth-android/commit/cc721536588eacfe66c77e4a39a6a56e9246d9d8#diff-9b72ca5f74c5da05204f881e94c67c02080ee1adbabfb06571ab3ca28e06569e but using a if and else statement to add compatability to the PS2 by switching from atomic to using a global mutex for the PS2.

Wolf3s commented 7 months ago

Hey, there nice basic port, Did you tested this on some source-port?

7dog123 commented 7 months ago

Not yet exactly. I'm trying to work on another project that uses Fluidsynth. I'm trying to port DoomRPG-RE to the PS2 since it uses fluidsynth as well as SDL2 and SDL2_mixer

Wolf3s commented 7 months ago

Not yet exactly. I'm trying to work on another project that uses Fluidsynth. I'm trying to port DoomRPG-RE to the PS2 since it uses fluidsynth as well as SDL2 and SDL2_mixer

DoomRPG-RE by gec on ps2 would be awesome although it´s seems to easy to port it, i could say that D64EX+ can be portable since on linux works well.

Wolf3s commented 7 months ago

obviously with this pull.

7dog123 commented 7 months ago

Yeah, but lets take this conversation for DoomRPG-RE on my fork of it and away from this pull request.

Wolf3s commented 7 months ago

Yeah, but lets take this conversation for DoomRPG-RE on my fork of it and away from this pull request.

Ok then, i saw you forked DoomRPG-RE.

fjtrujy commented 7 months ago

I'm totally fine adding this dependency, however how this is not the official fork, we would like to fork it in our side (ps2dev) a push the changes to a concrete branch called ee-VX.Y.Z where X.Y.Z belongs to the concrete version of the original library.

So if you agree, let me know the proper version, I will fork the original repo, and create that specific branch, and then you can perform a PR to that branch with your changes adding the PS2 support.

7dog123 commented 7 months ago

It uses the current version that's out as of now 2.3.5

Wolf3s commented 7 months ago

It uses the current version that's out as of now 2.3.5

Can you patch it with no sans-lib?

fjtrujy commented 6 months ago

It uses the current version that's out as of now 2.3.5

Sorry I have been busy, do you want me to fork it then?

Give the exact repo to fork and I will fork it in the ps2dev group

7dog123 commented 6 months ago

It uses the current version that's out as of now 2.3.5

Sorry I have been busy, do you want me to fork it then?

Give the exact repo to fork and I will fork it in the ps2dev group

It's alright and here's the repo I used.

https://github.com/DominusExult/fluidsynth-sans-glib and the branch that removes glib is sans_glib

fjtrujy commented 6 months ago

It uses the current version that's out as of now 2.3.5

Sorry I have been busy, do you want me to fork it then? Give the exact repo to fork and I will fork it in the ps2dev group

It's alright and here's the repo I used.

https://github.com/DominusExult/fluidsynth-sans-glib and the branch that removes glib is sans_glib

Here you have the branch pushed https://github.com/ps2dev/fluidsynth/tree/ee-sans_glib Now you can make a PR to that specific branch with the specific PS2 changes. Then once merged you can also use this on the ps2sdk-port (with cmake if possible)