search

ps2dev / ps2sdk-ports

Ports of useful libraries to PS2SDK
Other
107 stars 43 forks source link

Prepare makefiles for new lib #44

Closed fjtrujy closed 4 years ago

fjtrujy commented 4 years ago

Description

This PR is just a preparation before having the final PR for newlib. It just basically remove the local Makefile.eeglobal in ps2sdk-port and change all the Makefiles references to the ones under ps2dev

Thanks

rickgaiser commented 4 years ago

Thank you for changing this, I hope it can get merged. Using the Makefile from ps2dev makes ps2sdk-ports compile in a more standard way, as specified by the ps2sdk currently installed. I'm also expecting this change to fix the issues still being mentioned here https://github.com/ps2dev/ps2sdk-ports/issues/17. Since _EE is defined in the newly included Makefiles.

I think someday we should rename these Makefiles to something that does not include "samples" in the name, but that's what lots of libraries and apps seem to use these days.

fjtrujy commented 4 years ago

Now thanks to @AKuHAK this PR also include stlport and libtap back, both now are compiling.

Thanks!

sp193 commented 4 years ago

That is the thing: that eeglobal Makefile seems to be a sample, so it would make sense if this project provides its own global Makefile.