Closed AKuHAK closed 3 years ago
@ps2dev
Commit f10cd50 is not the best solution that I found, but I didn't found a solution on how to use if-else statements inside the bash function. MINGW32 CMake-based projects need to use mingw32-make
instead of make and don't support multithreading. And CMake needs -G "MinGW Makefiles"
flag. so I just created an alternative bash script for that purpose. If someone knows how to improve this solution, you can fix my PR.
Also romfs
port doesn't compile in MINGW32.
Instead of using make
and mingw32-make
isn't it possible to use $(MAKE) instead? Optional parameters are also used in other scripts, for instance something like this:
if [ ${OSVER:0:5} == MINGW ]; then
XTRA_OPTS=-G "MinGW Makefiles"
fi
I would prefer to keep this all in one script, since they are 90% the same.
@rickgaiser yes $(MAKE) will solve the problem, but I was not able to get it to work. If I check OSVER and define MAKE=mingw32-make
this just doesn't work. for unknown reason if-else didn't work in this bash script - I didn't found the reason why.
XTRA_OPTS=-G "MinGW Makefiles"
this also will not work - when I define variable in such way, everything after space character is cut off: it will be like -G "MinGW
and produces an error.
@rickgaiser with some tricky solutions, now it is working fine in all compatible environments. For now it is only needed to fix romfs
and this PR can be merged.
Everything is fixed, hope can be merged now. Will check multicore again
If you're ready I'll pull the PR?
I see it ready as well. You can merge @rickgaiser if @AKuHAK says it is ok. Thanks
Yes, it is ok now, you can merge it, it is supporting multicore.
Merged, thanks for supporting Windows @AKuHAK !
Fix zlib to always use libz.a instead of libzlib.a