search

ps2dev / ps2sdk-ports

Ports of useful libraries to PS2SDK
Other
107 stars 43 forks source link

unzip #74

Closed KrahJohlito closed 3 years ago

KrahJohlito commented 3 years ago

@rickgaiser can you take a look at this please, I have no idea if this is "complete".. I test compiled and it builds and installs and I can link to it in OPL but idk if this is the right way to go about it..

http://www.winimage.com/zLibDll/minizip.html this is the source of the complete lib, it seemed unnecessary to include zip and encryption/decryption so I've only included the unzip portion to keep the lib smaller.. no idea how to go about crediting the author so I just kept the changelog? etc etc

thanks for your time

rickgaiser commented 3 years ago

It looks like an improved version of minizip/unzip is included as part of zlib, that is already part of ps2sdk-ports: https://github.com/madler/zlib/tree/master/contrib/minizip

Is it possible to remove all source files from this PR, and only have the Makefile compile the sources from zlib?

rickgaiser commented 3 years ago

I think it's ready for merge. Convert from draft to normal PR and merge?

KrahJohlito commented 3 years ago

Sure thanks, I just wanted to test it first and it works all good.. haven't done much with makefiles before

rickgaiser commented 3 years ago

Thanks, the Makefile looks good. Merging.