ps2dev / ps2sdk

Homebrew PS2 SDK
Other
935 stars 133 forks source link

Libcglue get drive improvement fix #562

Closed uyjulian closed 6 months ago

AKuHAK commented 6 months ago

Maybe it will be better to negate this? Check if path is mass, mc or pfs use posix then check cdrom use windows slash for other use : only

fjtrujy commented 6 months ago

Maybe it will be better to negate this? Check if path is mass, mc or pfs use posix then check cdrom use windows slash for other use : only

To be honest, I'm not sure, feel free to do whatever you consider the best

uyjulian commented 6 months ago

I went ahead and added that change

fjtrujy commented 6 months ago

Are you sure this is the solution we want, Imagine the day of tomorrow a new driver added, then most probably we will do supporting the “/“, which means updating that list again. Then what is happening with HDD partitions? As we can have as many as we want, are these supporting “/“?

israpps commented 6 months ago

The list of drives that need special treatment is smaller than the ones that allow /. Deal with edge cases and default to :/

Edge cases

Versus

uyjulian commented 6 months ago

Yeah I think it would be better to default to posix path handling. I changed it back to to the other behavior